Open
Conversation
sagizaidor
reviewed
Jan 30, 2021
|
|
||
| speedy_meetings_enabled = Column(Boolean, default=False) | ||
|
|
||
| def has_speedy_meetings_enabled(self) -> bool: |
Contributor
There was a problem hiding this comment.
מה המטרה שך הפנציה הזאת? למה לקרוא לה ולא פשוט לא user.speedy_meetings_enabled?
|
|
||
| participants = relationship("UserEvent", back_populates="events") | ||
|
|
||
| def get_event_duration(self): |
Contributor
There was a problem hiding this comment.
זה דבר נהוג להכניס פונקציות לModels ולא להוציא את זה לקבצים בinternal?
בדקת את זה לפני?
שואל באמת כי זה פעם ראשונה שאני רואה
Member
|
This is a good start :) Keep going |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.